mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-29 07:06:06 +00:00
a27c416b89
The ScopedString class has two functions named append. One takes
a va_list, but on some platforms va_list is typedef'd to char*.
That means that this call:
std::string value;
Str.append("print this string %s", value.c_str());
The compiler can incorrectly think this is the va_list function,
leading to crashes when calling this. To fix this, change the name
of the va_list function to be vappend to avoid this.
Fix https://github.com/llvm/llvm-project/issues/62893
Reviewed By: Chia-hungDuan
Differential Revision: https://reviews.llvm.org/D153389
44 lines
1.2 KiB
C++
44 lines
1.2 KiB
C++
//===-- string_utils.h ------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef SCUDO_STRING_UTILS_H_
|
|
#define SCUDO_STRING_UTILS_H_
|
|
|
|
#include "internal_defs.h"
|
|
#include "vector.h"
|
|
|
|
#include <stdarg.h>
|
|
|
|
namespace scudo {
|
|
|
|
class ScopedString {
|
|
public:
|
|
explicit ScopedString() { String.push_back('\0'); }
|
|
uptr length() { return String.size() - 1; }
|
|
const char *data() { return String.data(); }
|
|
void clear() {
|
|
String.clear();
|
|
String.push_back('\0');
|
|
}
|
|
void vappend(const char *Format, va_list Args);
|
|
void append(const char *Format, ...) FORMAT(2, 3);
|
|
void output() const { outputRaw(String.data()); }
|
|
void reserve(size_t Size) { String.reserve(Size + 1); }
|
|
|
|
private:
|
|
Vector<char> String;
|
|
};
|
|
|
|
int formatString(char *Buffer, uptr BufferLength, const char *Format, ...)
|
|
FORMAT(3, 4);
|
|
void Printf(const char *Format, ...) FORMAT(1, 2);
|
|
|
|
} // namespace scudo
|
|
|
|
#endif // SCUDO_STRING_UTILS_H_
|