llvm-project/llvm/lib/IR/SSAContext.cpp
Sameer Sahasrabuddhe f6e22f2f63 [llvm][Uniformity] A phi with an undef argument is not always divergent
The uniformity analysis treated an undef argument to phi to be distinct from any
other argument, equivalent to calling PHINode::hasConstantValue() instead of
PHINode::hasConstantOrUndefValue(). Such a phi was reported as divergent. This
is different from the older divergence analysis which treats such a phi as
uniform. Fixed uniformity analysis to match the older behaviour.

The original behaviour was added to DivergenceAnalysis in D19013. But it is not
clear if relying on the undef value is safe. The defined values are not constant
per se; they just happen to be uniform and the non-constant uniform value may
not dominate the PHI.

Reviewed By: ruiling

Differential Revision: https://reviews.llvm.org/D144254
2023-02-20 14:26:43 +05:30

104 lines
3.1 KiB
C++

//===- SSAContext.cpp -------------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
/// \file
///
/// This file defines a specialization of the GenericSSAContext<X>
/// template class for LLVM IR.
///
//===----------------------------------------------------------------------===//
#include "llvm/IR/SSAContext.h"
#include "llvm/IR/Argument.h"
#include "llvm/IR/BasicBlock.h"
#include "llvm/IR/Function.h"
#include "llvm/IR/Instruction.h"
#include "llvm/IR/Instructions.h"
#include "llvm/Support/raw_ostream.h"
using namespace llvm;
Value *SSAContext::ValueRefNull = nullptr;
void SSAContext::setFunction(Function &Fn) { F = &Fn; }
BasicBlock *SSAContext::getEntryBlock(Function &F) {
return &F.getEntryBlock();
}
const BasicBlock *SSAContext::getEntryBlock(const Function &F) {
return &F.getEntryBlock();
}
void SSAContext::appendBlockDefs(SmallVectorImpl<Value *> &defs,
BasicBlock &block) {
for (auto &instr : block.instructionsWithoutDebug(/*SkipPseudoOp=*/true)) {
if (instr.isTerminator())
break;
if (instr.getType()->isVoidTy())
continue;
auto *def = &instr;
defs.push_back(def);
}
}
void SSAContext::appendBlockDefs(SmallVectorImpl<const Value *> &defs,
const BasicBlock &block) {
for (auto &instr : block) {
if (instr.isTerminator())
break;
defs.push_back(&instr);
}
}
void SSAContext::appendBlockTerms(SmallVectorImpl<Instruction *> &terms,
BasicBlock &block) {
terms.push_back(block.getTerminator());
}
void SSAContext::appendBlockTerms(SmallVectorImpl<const Instruction *> &terms,
const BasicBlock &block) {
terms.push_back(block.getTerminator());
}
const BasicBlock *SSAContext::getDefBlock(const Value *value) const {
if (const auto *instruction = dyn_cast<Instruction>(value))
return instruction->getParent();
return nullptr;
}
bool SSAContext::comesBefore(const Instruction *lhs, const Instruction *rhs) {
return lhs->comesBefore(rhs);
}
bool SSAContext::isConstantOrUndefValuePhi(const Instruction &Instr) {
if (auto *Phi = dyn_cast<PHINode>(&Instr))
return Phi->hasConstantOrUndefValue();
return false;
}
Printable SSAContext::print(const Value *V) const {
return Printable([V](raw_ostream &Out) { V->print(Out); });
}
Printable SSAContext::print(const Instruction *Inst) const {
return print(cast<Value>(Inst));
}
Printable SSAContext::print(const BasicBlock *BB) const {
if (!BB)
return Printable([](raw_ostream &Out) { Out << "<nullptr>"; });
if (BB->hasName())
return Printable([BB](raw_ostream &Out) { Out << BB->getName(); });
return Printable([BB](raw_ostream &Out) {
ModuleSlotTracker MST{BB->getParent()->getParent(), false};
MST.incorporateFunction(*BB->getParent());
Out << MST.getLocalSlot(BB);
});
}