From 13d88b634087f4f0d45c5ba95db81337af92d558 Mon Sep 17 00:00:00 2001
From: charleshofer <Charles.Hofer@amd.com>
Date: Mon, 24 Mar 2025 11:26:31 -0500
Subject: [PATCH] Add back raw totals in JSON reports (#281)
---
.github/workflows/rocm-ci.yml | 1 -
tests/conftest.py | 8 +-------
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/.github/workflows/rocm-ci.yml b/.github/workflows/rocm-ci.yml
index 1f58ffe8e..3eda5116d 100644
--- a/.github/workflows/rocm-ci.yml
+++ b/.github/workflows/rocm-ci.yml
@@ -60,7 +60,6 @@ jobs:
path: ./dist/*.whl
- name: Run tests
env:
- ROCM_TEST_INCLUDE_SKIPS: "1"
GPU_COUNT: "8"
GFX: "gfx90a"
run: |
diff --git a/tests/conftest.py b/tests/conftest.py
index 78e56a831..f08cb04a6 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -1,14 +1,8 @@
-import os
import pytest
-INCLUDE_SKIPS = os.getenv("ROCM_TEST_INCLUDE_SKIPS", default=False)
-
@pytest.hookimpl(optionalhook=True)
def pytest_json_modifyreport(json_report):
"""Get rid of skipped tests in reporting. We only care about xfails."""
- if (not INCLUDE_SKIPS
- and "summary" in json_report
- and "total" in json_report["summary"]):
+ if "summary" in json_report and "total" in json_report["summary"]:
json_report["summary"]["unskipped_total"] = json_report["summary"]["total"] - json_report["summary"].get("skipped", 0)
- del json_report["summary"]["total"]