mirrors/rocm_jax
1
0
Fork 0
mirror of https://github.com/ROCm/jax.git synced 2025-04-19 05:16:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert to requiring Bazel 0.24 for JAX builds.

Browse Source 
It turns out TF does not fully support 0.25 yet.

Add a check for a maximum bazel version to the build script.

Fixes #702.
This commit is contained in:
Peter Hawkins 2019-05-12 09:25:10 -04:00
parent 78c804772e
commit 5599f473f0
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
build/build.py
View File

@ -60,19 +60,19 @@ def get_python_bin_path(python_bin_path_flag):
# Bazel
BAZEL_BASE_URI = "https://github.com/bazelbuild/bazel/releases/download/0.25.1/"
BAZEL_BASE_URI = "https://github.com/bazelbuild/bazel/releases/download/0.24.1/"
BazelPackage = collections.namedtuple("BazelPackage", ["file", "sha256"])
bazel_packages = {
"Linux":
BazelPackage(
file="bazel-0.25.1-linux-x86_64",
file="bazel-0.24.1-linux-x86_64",
sha256=
"9fe5a74fa319e771b0328b42f79bf00496592fd9c0989247b4dd322ce9a082e9"),
"e18e2877e18a447eb5d94f5efbec375366d82af6443c6a83a93c62657a7b1c32"),
"Darwin":
BazelPackage(
file="bazel-0.25.1-darwin-x86_64",
file="bazel-0.24.1-darwin-x86_64",
sha256=
"436e34cf8cf47f43620a70927e3fcdb1f23659e3e0ae22e42ff8b6d8b7626cfa"),
"cf763752550050d117e03659aaa6ccd6f97da1f983a6029300a497fdaeaaec46"),
}
@ -140,8 +140,8 @@ def get_bazel_path(bazel_path_flag):
sys.exit(-1)
def check_bazel_version(bazel_path, min_version):
"""Checks Bazel's version is at least `min_version`."""
def check_bazel_version(bazel_path, min_version, max_version):
"""Checks Bazel's version is in the range [`min_version`, `max_version`)."""
version_output = shell([bazel_path, "--bazelrc=/dev/null", "version"])
match = re.search("Build label: *([0-9\\.]+)[^0-9\\.]", version_output)
if match is None:
@ -155,6 +155,12 @@ def check_bazel_version(bazel_path, min_version):
print("Outdated bazel revision (>= {} required, found {})".format(
min_version, version))
sys.exit(0)
if max_version is not None:
max_ints = [int(x) for x in max_version.split(".")]
if actual_ints >= max_ints:
print("Please downgrade your bazel revision to build JAX (>= {} and < {}"
" required, found {})".format(min_version, max_version, version))
sys.exit(0)
BAZELRC_TEMPLATE = """
@ -283,7 +289,7 @@ def main():
# Find a working Bazel.
bazel_path = get_bazel_path(args.bazel_path)
check_bazel_version(bazel_path, "0.25.0")
check_bazel_version(bazel_path, min_version="0.24.0", max_version="0.25.0")
print("Bazel binary path: {}".format(bazel_path))
python_bin_path = get_python_bin_path(args.python_bin_path)