mirrors/rocm_jax
1
0
Fork 0
mirror of https://github.com/ROCm/jax.git synced 2025-04-16 11:56:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify bazel version check

Browse Source
This commit is contained in:
Daniel Bershatsky 2021-02-13 16:32:21 +03:00
parent c71a4f5871
commit 96193cef12
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
build/build.py
View File

@ -145,7 +145,7 @@ def download_and_verify_bazel():
def get_bazel_paths(bazel_path_flag):
"""Yields a sequence of a guess about bazel path. Some of sequence elements
"""Yields a sequence of guesses about bazel path. Some of sequence elements
can be None. The resulting iterator is lazy and potentially has a side
effects."""
yield bazel_path_flag
@ -153,23 +153,23 @@ def get_bazel_paths(bazel_path_flag):
yield download_and_verify_bazel()
def get_bazel_path(bazel_path_flag, min_version, max_version):
def get_bazel_path(bazel_path_flag):
"""Returns the path to a Bazel binary, downloading Bazel if not found. Also,
it checks Bazel's version is in the range [`min_version`, `max_version`).
it checks Bazel's version at lease newer than 2.0.0.
NOTE Manual version check is reasonably only for bazel < 2.0.0. Newer bazel
releases performs version check against .bazelversion (see for details
https://blog.bazel.build/2019/12/19/bazel-2.0.html#other-important-changes).
"""
for path in filter(None, get_bazel_paths(bazel_path_flag)):
if check_bazel_version(path, min_version, max_version):
if check_bazel_version(path):
return path
print("Cannot find or download bazel. Please install bazel.")
sys.exit(-1)
def check_bazel_version(bazel_path, min_version, max_version):
def check_bazel_version(bazel_path):
try:
version_output = shell([bazel_path, "--bazelrc=/dev/null", "version"])
except subprocess.CalledProcessError:
@ -177,15 +177,9 @@ def check_bazel_version(bazel_path, min_version, max_version):
match = re.search("Build label: *([0-9\\.]+)[^0-9\\.]", version_output)
if match is None:
return False
version = match.group(1)
min_ints = [int(x) for x in min_version.split(".")]
actual_ints = [int(x) for x in match.group(1).split(".")]
if min_ints > actual_ints:
if (2, 0, 0) > actual_ints:
return False
if max_version is not None:
max_ints = [int(x) for x in max_version.split(".")]
if actual_ints >= max_ints:
return False
return True
@ -437,7 +431,7 @@ def main():
os.chdir(os.path.dirname(__file__ or args.prog) or '.')
# Find a working Bazel.
bazel_path = get_bazel_path(args.bazel_path, min_version="2.0.0", max_version=None)
bazel_path = get_bazel_path(args.bazel_path)
print("Bazel binary path: {}".format(bazel_path))
python_bin_path = get_python_bin_path(args.python_bin_path)