mirror of
https://github.com/ROCm/jax.git
synced 2025-04-14 10:56:06 +00:00
4f394828e1
This change does a few things (arguably too many): 1. The key change here is that it fixes the handler registration in `jaxlib/gpu/gpu_kernels.cc` for the two handlers that use the XLA FFI API. A previous attempt at this change caused downstream issues because of duplicate registrations, but we were able to fix that directly in XLA. 2. A second related change is to declare and define the XLA FFI handlers consistently using the `XLA_FFI_DECLARE_HANDLER_SYMBOL` and `XLA_FFI_DEFINE_HANDLER_SYMBOL` macros. We need to use these macros instead of the `XLA_FFI_DEFINE_HANDLER` version which produces a lambda, so that when XLA checks the address of the handler during registration it is consistent. Without this change, the downstream tests would continue to fail. 3. The final change is to consolidate the `cholesky_update_kernel` and `lu_pivot_kernels` implementations into a common `linalg_kernels` target. This makes the implementation of the `_linalg` nanobind module consistent with the other targets within `jaxlib/gpu`, and (I think!) makes the details easier to follow. This last change is less urgent, but it was what I set out to do so that's why I'm suggesting them all together, but I can split this in two if that would be preferred. PiperOrigin-RevId: 651107659
73 lines
2.6 KiB
C++
73 lines
2.6 KiB
C++
/* Copyright 2019 The JAX Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
==============================================================================*/
|
|
|
|
#ifndef JAXLIB_KERNEL_NANOBIND_HELPERS_H_
|
|
#define JAXLIB_KERNEL_NANOBIND_HELPERS_H_
|
|
|
|
#include <string>
|
|
#include <type_traits>
|
|
|
|
#include "nanobind/nanobind.h"
|
|
#include "absl/base/casts.h"
|
|
#include "jaxlib/kernel_helpers.h"
|
|
#include "xla/ffi/api/c_api.h"
|
|
#include "xla/tsl/python/lib/core/numpy.h" // NOLINT
|
|
|
|
namespace jax {
|
|
|
|
// Caution: to use this type you must call tsl::ImportNumpy() in your module
|
|
// initialization function. Otherwise PyArray_DescrCheck will be nullptr.
|
|
class dtype : public nanobind::object {
|
|
public:
|
|
NB_OBJECT_DEFAULT(dtype, object, "dtype", PyArray_DescrCheck); // NOLINT
|
|
|
|
int itemsize() const { return nanobind::cast<int>(attr("itemsize")); }
|
|
|
|
/// Single-character code for dtype's kind.
|
|
/// For example, floating point types are 'f' and integral types are 'i'.
|
|
char kind() const { return nanobind::cast<char>(attr("kind")); }
|
|
};
|
|
|
|
// Descriptor objects are opaque host-side objects used to pass data from JAX
|
|
// to the custom kernel launched by XLA. Currently simply treat host-side
|
|
// structures as byte-strings; this is not portable across architectures. If
|
|
// portability is needed, we could switch to using a representation such as
|
|
// protocol buffers or flatbuffers.
|
|
|
|
// Packs a descriptor object into a nanobind::bytes structure.
|
|
// UnpackDescriptor() is available in kernel_helpers.h.
|
|
template <typename T>
|
|
nanobind::bytes PackDescriptor(const T& descriptor) {
|
|
std::string s = PackDescriptorAsString(descriptor);
|
|
return nanobind::bytes(s.data(), s.size());
|
|
}
|
|
|
|
template <typename T>
|
|
nanobind::capsule EncapsulateFunction(T* fn) {
|
|
return nanobind::capsule(absl::bit_cast<void*>(fn),
|
|
"xla._CUSTOM_CALL_TARGET");
|
|
}
|
|
|
|
template <typename T>
|
|
nanobind::capsule EncapsulateFfiHandler(T* fn) {
|
|
static_assert(std::is_invocable_r_v<XLA_FFI_Error *, T, XLA_FFI_CallFrame *>,
|
|
"Encapsulated function must be an XLA FFI handler");
|
|
return nanobind::capsule(absl::bit_cast<void*>(fn));
|
|
}
|
|
|
|
} // namespace jax
|
|
|
|
#endif // JAXLIB_KERNEL_NANOBIND_HELPERS_H_
|