mirror of
https://github.com/ROCm/jax.git
synced 2025-04-19 05:16:06 +00:00
47f2f091bc
The crashes on Mac were, as best we can tell, unrelated to this PR. Original description: Change the pocketfft custom kernel in jaxlib to generate its flatbuffer descriptor in C++ instead. Surprisingly this code is actually much more readable in C++ because the flatbuffers Python API does not have a readable but less efficient API. Breaking changes to the flatbuffers Python APIs have caused breakage in JAX in the past, and we can avoid the dependency completely without much work. PiperOrigin-RevId: 457819042
69 lines
2.5 KiB
C++
69 lines
2.5 KiB
C++
/* Copyright 2020 Google LLC
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
==============================================================================*/
|
|
|
|
#include <complex>
|
|
#include <vector>
|
|
|
|
#include "jaxlib/kernel_pybind11_helpers.h"
|
|
#include "jaxlib/pocketfft_generated.h"
|
|
#include "jaxlib/pocketfft_kernels.h"
|
|
#include "include/pybind11/pybind11.h"
|
|
#include "include/pybind11/stl.h"
|
|
|
|
namespace py = pybind11;
|
|
|
|
namespace jax {
|
|
namespace {
|
|
|
|
py::bytes BuildPocketFftDescriptor(const std::vector<uint64_t>& shape,
|
|
bool is_double, int fft_type,
|
|
const std::vector<uint64_t>& fft_lengths,
|
|
const std::vector<uint64_t>& strides_in,
|
|
const std::vector<uint64_t>& strides_out,
|
|
const std::vector<uint32_t>& axes,
|
|
bool forward, double scale) {
|
|
PocketFftDescriptorT descriptor;
|
|
descriptor.shape = shape;
|
|
descriptor.fft_type = static_cast<PocketFftType>(fft_type);
|
|
descriptor.dtype =
|
|
is_double ? PocketFftDtype_COMPLEX128 : PocketFftDtype_COMPLEX64;
|
|
descriptor.strides_in = strides_in;
|
|
descriptor.strides_out = strides_out;
|
|
descriptor.axes = axes;
|
|
descriptor.forward = forward;
|
|
descriptor.scale = scale;
|
|
flatbuffers::FlatBufferBuilder fbb;
|
|
fbb.Finish(PocketFftDescriptor::Pack(fbb, &descriptor));
|
|
return py::bytes(reinterpret_cast<char*>(fbb.GetBufferPointer()),
|
|
fbb.GetSize());
|
|
}
|
|
|
|
py::dict Registrations() {
|
|
pybind11::dict dict;
|
|
dict["pocketfft"] = EncapsulateFunction(PocketFft);
|
|
return dict;
|
|
}
|
|
|
|
PYBIND11_MODULE(_pocketfft, m) {
|
|
m.def("registrations", &Registrations);
|
|
m.def("pocketfft_descriptor", &BuildPocketFftDescriptor, py::arg("shape"),
|
|
py::arg("is_double"), py::arg("fft_type"), py::arg("fft_lengths"),
|
|
py::arg("strides_in"), py::arg("strides_out"), py::arg("axes"),
|
|
py::arg("forward"), py::arg("scale"));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace jax
|